Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message sending #294

Open
h1divp opened this issue Sep 20, 2024 · 5 comments
Open

Fix message sending #294

h1divp opened this issue Sep 20, 2024 · 5 comments
Assignees
Labels
Backend📡 Issues corresponding to the backend/API. Bug Something isn't working Frontend 🖥 Issues corresponding to the frontend/client. Help wanted Someone needs to work on this Medium You should have some familiarity with our codebase to work on this issue

Comments

@h1divp
Copy link
Collaborator

h1divp commented Sep 20, 2024

If someone sends a message after setting up the project for the first time it's likely to not be received by nearby devices anymore???? what????

I think this has to deal with the socket API and have done a bit of research into this issue last month. If you have any leads please comment.

Multiple people can be assigned to this issue.

@h1divp h1divp added Bug Something isn't working Backend📡 Issues corresponding to the backend/API. Frontend 🖥 Issues corresponding to the frontend/client. Medium You should have some familiarity with our codebase to work on this issue labels Sep 20, 2024
@h1divp h1divp self-assigned this Sep 20, 2024
@h1divp
Copy link
Collaborator Author

h1divp commented Sep 20, 2024

It looks like that after the the app loads, and a refresh is caused by a file change after a file is saved including a new change (NOT by refreshing through pressing 'r' in the expo cli), users can connect, and both messages and a locations can be sent by the client, which the server is able to receive.

@h1divp
Copy link
Collaborator Author

h1divp commented Sep 20, 2024

Note: if app refreshes occur, old ConnectedUsers documents are not cleaned up

@h1divp
Copy link
Collaborator Author

h1divp commented Sep 20, 2024

Message and location communication fully works with the above described method.
I expect the bug to be caused by improper socket mounting.

@h1divp h1divp added the Help wanted Someone needs to work on this label Sep 20, 2024
@h1divp
Copy link
Collaborator Author

h1divp commented Sep 20, 2024

After the above method is done to fix message sending, communication also seems to still work after refreshing through console and even after re-running npm start.

@h1divp
Copy link
Collaborator Author

h1divp commented Sep 20, 2024

Above fix also works even after ConnectedUsers is deleted, restarting the app afterwards. New users also seem to be fine connecting...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend📡 Issues corresponding to the backend/API. Bug Something isn't working Frontend 🖥 Issues corresponding to the frontend/client. Help wanted Someone needs to work on this Medium You should have some familiarity with our codebase to work on this issue
Projects
None yet
Development

No branches or pull requests

1 participant