New regression tests for V2 surface coldstart files

[GeorgeGayno-NOAA]

PR Author Checklist:

• I have linked PR's from all sub-components involved in section below.
• I am confirming reviews are completed in ALL sub-component PR's.
• I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • LOG: Baselined to my branch. RegressionTests_hera.log
• I have added the list of all failed regression tests to "Anticipated changes" section.
• I have filled out all sections of the template.

Description

The UFS_UTILS chgres_cube program was updated for fractional (partial land/non-land) grids and a new version of the surface coldstart file is output. This new file format will work with either fractional or non-fractional cases. Create three new regression tests that use the new file format.

Commit Message

- Add three new regression tests for version 2 of the surface coldstart file. (Closes #1977)

Linked Issues and Pull Requests

Associated UFSWM Issue to close

• Fixes New regression tests for v2 surface coldstart files #1977.

Subcomponent Pull Requests

• Update i/o routines for new surface coldstart file. NOAA-EMC/fv3atm#698

Blocking Dependencies

N/A

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Anticipated Changes

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any current regression test.
• Changes are expected to the following tests:

Tests effected by changes in this PR:

• Three new regression tests based on the existing 'control_c48', 'control_p8' and 'cpld_control_p8' tests

New coldstart files for these tests are in /scratch1/NCEPDEV/da/George.Gayno/ufs_utils.git/chgres_cube.fractional/RT

• control_c48.v2.sfc - ./FV3_input_data48/INPUT_L127.v2.sfc
• control_p8.v2.sfc - ./FV3_input_data/INPUT_L127.v2.sfc
• cpld_control_p8.v2.sfc - ./FV3_input_data/INPUT_L127_mx100.v2.sfc

New baseline files will need to be hosted for these new tests.

All regression tests passed except for the three new tests (because the new tests do not have baseline files yet).

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Code Managers Log

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
  • N/A

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[DeniseWorthen]

@GeorgeGayno-NOAA We're adding a Commit Message requirement to the PRs. Please add one in the space provided.

[GeorgeGayno-NOAA]

@GeorgeGayno-NOAA Note that feature branch is recommended but your branch syncs ok. Then, we can move on to commit. We will try to combine in #2115 to this pr after your branch is synced up. @BrianCurtis-NOAA FYI: #2111 is combined ok into #2115

My branch looks synced up. Did you do that?

[jkbk2004]

@GeorgeGayno-NOAA Note that feature branch is recommended but your branch syncs ok. Then, we can move on to commit. We will try to combine in #2115 to this pr after your branch is synced up. @BrianCurtis-NOAA FYI: #2111 is combined ok into #2115

My branch looks synced up. Did you do that?

@GeorgeGayno-NOAA I pushed a few commits to sync up. This pr is ready. Hera full test passes ok. There was a minor issue on #2115 side. The issue was fixed but we are not going to combine with any other PRs. @BrianCurtis-NOAA FYI @zach1221 @FernandoAndrade-NOAA can you pick up from here.

[zach1221]

Hey, @BrianCurtis-NOAA . How are acorn/wcoss coming along?

[BrianCurtis-NOAA]

gnv1_nested is causing issues on WCOSS2. I've tried 2 comparisons, redid that baseline and compared against it again and it still failed in comparison. This test needs to be disabled on WCOSS2 and the developer of that test needs to find out why it isn't reproducing it's own baselines.

[zach1221]

gnv1_nested is causing issues on WCOSS2. I've tried 2 comparisons, redid that baseline and compared against it again and it still failed in comparison. This test needs to be disabled on WCOSS2 and the developer of that test needs to find out why it isn't reproducing it's own baselines.

Brian, I can make an issue and make note of each machine this is occurring on.

[zach1221]

The Hera ORTs should be done shortly and we can move on to start merging.

[zach1221]

Testing is complete. Moving to merge the fv3atm sub-pr.