Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motion v0.5.0 does not work with ViewComponent >= v2.35.0 #111

Open
bert-mccutchen opened this issue Jul 9, 2021 · 1 comment
Open

Motion v0.5.0 does not work with ViewComponent >= v2.35.0 #111

bert-mccutchen opened this issue Jul 9, 2021 · 1 comment

Comments

@bert-mccutchen
Copy link

Motion fails to serialize the component due to ViewComponent v2.35.0 changing some instance variable names:
ViewComponent/view_component#967

This means @controller and @helpers are now @__vc_controller and @__vc_helpers, which are not excluded here:
https://github.com/unabridged/motion/blob/v0.5.0/lib/motion/component/rendering.rb#L8-L29

As far as I can tell, this only happens when you have a form in the view component's HTML.
@bert-mccutchen
Copy link
Author

bert-mccutchen commented Jul 11, 2021 •
edited
Loading

Looking into this further... There are actually many more that are of issue, for example @variant is now @__vc_variant. The entire list will need to be reviewed and updated with a patch.

@r3trofitted r3trofitted mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bert-mccutchen