Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation should live in cms-prototype-blocks? #235

Open
jna-unikent opened this issue Dec 18, 2017 · 1 comment
Open

Schema validation should live in cms-prototype-blocks? #235

jna-unikent opened this issue Dec 18, 2017 · 1 comment

Comments

@jna-unikent
Copy link
Contributor

It seems the right place to validate the json schema would be in the cms prototype blocks repo since the definitions live there.

It would be good for the validation to be run when stuff is committed into that repo.

Alternatively we could pull out the validation into its own repo and then pull it into both astro and cms-prototype blocks.

https://github.com/unikent/astro/blob/develop/package.json#L12

@samyapp
Copy link
Contributor

samyapp commented Dec 21, 2017

Probably best to have it in both places, as its possible we may have multiple "cms-prototype-blocks" repos in the future being mixed into the main build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants