Fix issue where str dtype in a multiindex dataframe schema results in invalid example #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Glenn Sugar <[email protected]>
gsugar87
force-pushed
the
bugfix/1049
branch
from
da852ad to
1444ce4
Compare
|
Hey, any chance a maintainer could look at this PR? It's a simple one-liner. |
|
Could someone take a look at this PR? It's pretty simple and solves an annoying bug |
|
hmm, CI isn't running, lemme close/open |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
==========================================
- Coverage 97.23% 94.23% -3.01%
==========================================
Files 63 91 +28
Lines 4710 6975 +2265
==========================================
+ Hits 4580 6573 +1993
- Misses 130 402 +272 ☔ View full report in Codecov by Sentry. |
Looks like CI ran. Any chance you could review? |
|
Ping on this. It would be great to get this simple fix in |
cosmicBboy
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Glenn Sugar [email protected]
Fixes #1049