Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with oauth-token instead of user/password #9

Open
simonfranz opened this issue Aug 27, 2016 · 1 comment
Open

Working with oauth-token instead of user/password #9

simonfranz opened this issue Aug 27, 2016 · 1 comment

Comments

@simonfranz
Copy link

HI there,
I've been working on an oauth login to my application. I was uncomfortable that every user has to save their password in my applocation.
A login with oauth to jira can be done with: https://github.com/SocialiteProviders/Jira, (docs at http://socialiteproviders.github.io/providers/jira/). There was a bug while getting the access token. which is fixed with a PR I made.

Currently I'm not able to get the information where to put the access token in the request.
I think this would be a good addition to include the auth-token in the request instead of the username/password.

I'll wait till #8 is merged to create a additional PR to add the functionality from #3 and hopefully add the oauth token to the request.

Is there a possibility that this PR will get accepted?

@univerze
Copy link
Owner

univerze commented Sep 3, 2016

Hi @simonfranz
At the moment I'm struggling to find time to work on this library, I try my best and add new functions to the code a bit more Eloquent style. I will have a look at the oauth features as well and find out a best practice.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants