Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIDS] Give Heading default props per level #1053

Open
kyleshike opened this issue Oct 31, 2023 · 0 comments
Open

[UIDS] Give Heading default props per level #1053

kyleshike opened this issue Oct 31, 2023 · 0 comments
Labels
good first issue Don't know where to start? Help us out here!

Comments

@kyleshike
Copy link
Collaborator

Description

[Description of the problem / solution, screenshots, explanation of approach, links to docs, etc.]
Currently in TS, the Heading component requires all its props be defined. We should provide some sane defaults, perhaps for levels 1-6

User Stories

  • As a [persona], I want [feature/task] so that [benefit/reason].
    As an engineer on Rails Server, I want to use the Heading component and not have to think about size, weight, etc.

Acceptance Criteria

  • <Heading level={1}> through <Heading level={6}> should each have default values for size and weight.
@kyleshike kyleshike changed the title [UIDS] Give Heading sane defaultprops [UIDS] Give Heading default props per level Oct 31, 2023
@kyleshike kyleshike added the good first issue Don't know where to start? Help us out here! label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Don't know where to start? Help us out here!
Projects
None yet
Development

No branches or pull requests

1 participant