WIP: Propogate boundary conditions to old values #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesn't handle deleting constraints.
|
Thanks for the proposal! This sounds like a reasonable thing to do. Before merging, I'll need to figure out why the CI has fallen over (and why it hasn't notified me for the last month that it isn't working) and make sure that we get clean tests. |
|
@Maxwellfire: I've finally fixed the CI (#925) and your code both passes and seems like a good idea. Would you like to submit this PR for review? |
|
@guyer I think that I should include some code that accounts for deleting boundary conditions as well, and take a final check that my code covers all the cases. Once I do that, I'll submit for review |
|
Checking in to see if you've had a chance to polish this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft WIP:
Currently fipy does not apply boundary conditions to the old values stored in variables. This means that when you compute some metrics (like the time derivative of a quantity on the boundary), you don't get the expected answer.
I'm making this draft pull request to start a conversation and see if this is something that would be helpful to contribute upstream once polished up. I've been using these changes locally for a while.