Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging #53

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Fix logging #53

merged 2 commits into from
Feb 22, 2024

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Feb 22, 2024

This PR attempts to fix logging again by reviewing how the context is initialized and how the existing contexts are updated

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mackdk mackdk requested a review from mcalmer February 22, 2024 10:31
@mackdk mackdk marked this pull request as ready for review February 22, 2024 10:31
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this is only about logging, not the dependency change. So seems to be ok

@mackdk
Copy link
Contributor Author

mackdk commented Feb 22, 2024

Seems this is only about logging, not the dependency change.

Yes, the change for the dependency is only in the spec file in OBS. The maven declaration only contains the correct lang3 reference.

@mackdk mackdk merged commit bb97930 into uyuni-project:master Feb 22, 2024
1 check passed
@mackdk mackdk deleted the fix-logging branch February 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants