Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SonarCloud issues #57

Merged
merged 27 commits into from
Nov 5, 2024
Merged

Fix SonarCloud issues #57

merged 27 commits into from
Nov 5, 2024

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented May 7, 2024

This PR refactor the code to address multiple issues discovered by SonarCloud

@mackdk mackdk force-pushed the branch-fix-sonarcloud-issues branch from ad7ff9a to b338893 Compare May 8, 2024 13:10
@mackdk mackdk changed the title WIP - Fix SonarCloud issues Fix SonarCloud issues May 15, 2024
@mackdk mackdk force-pushed the branch-fix-sonarcloud-issues branch from b338893 to 726b312 Compare May 28, 2024 14:58
@mackdk mackdk force-pushed the branch-fix-sonarcloud-issues branch from 726b312 to 3f40da8 Compare June 4, 2024 15:06
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mackdk mackdk requested review from lucidd and mcalmer June 11, 2024 09:24
@mackdk mackdk marked this pull request as ready for review June 11, 2024 09:24
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackdk mackdk merged commit 55f1b64 into master Nov 5, 2024
2 checks passed
@mackdk mackdk deleted the branch-fix-sonarcloud-issues branch November 5, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants