Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchase order status set to requisition when all lines are either invoiced or cancelled #252

Open
steveblamey opened this issue Sep 29, 2021 · 1 comment

Comments

@steveblamey
Copy link
Member

If a purchase order has invoiced lines and 2 or more open lines, when an open line is cancelled the order reverts to requisition.

This is by design as any order change should require re-authorisation. However, we need to review the logic around POrder::save() in the model. If the owner is also able to authorise, then no change to the order status should be necessary,

See:

if (!is_null($this->authorised_by) && EGS_USERNAME == $this->authorised_by && $this->base_net_value>0 && $porderlines_summary->count()>0)

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 21, 2023
@steveblamey steveblamey added bug and removed wontfix labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant