Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate uniforms-bridge-simple-schema package #1323

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

piotrpospiech
Copy link
Collaborator

Deprecate the Meteor SimpleSchema bridge, as mentioned in this issue (#1315).

  • Removed the whole package from the uniforms repository
  • Removed package from the labeler
  • Removed SimpleSchema from the Readme file
  • Removed the uniforms-bridge-simple-schema package from the package.json files
  • Removed bridge from tsconfig references
  • Removed mocks and removed __mocks__ directory config

Note

I left the SimpleSchemaBridge docs. We will keep that in the uniforms v3 docs.

@piotrpospiech piotrpospiech added this to the v4.0 milestone Apr 20, 2024
@piotrpospiech piotrpospiech self-assigned this Apr 20, 2024
@github-actions github-actions bot added Area: Bridge Affects some of the bridge packages Area: Core Affects the uniforms package Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies) Bridge: SimpleSchema Affects the uniforms-bridge-simple-schema package labels Apr 20, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (1436d4c) to head (ee87287).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   94.37%   94.24%   -0.14%     
==========================================
  Files         229      226       -3     
  Lines        3754     3664      -90     
  Branches     1011      989      -22     
==========================================
- Hits         3543     3453      -90     
  Misses         81       81              
  Partials      130      130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kestarumper kestarumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add warn admonition to mark it in the docs as deprecated.

@piotrpospiech piotrpospiech requested a review from kestarumper May 3, 2024 04:28
kestarumper
kestarumper previously approved these changes May 10, 2024
zendranm
zendranm previously approved these changes May 24, 2024
Monteth
Monteth previously approved these changes May 24, 2024
@piotrpospiech piotrpospiech dismissed stale reviews from Monteth, zendranm, and kestarumper via ee87287 May 24, 2024 11:09
@kestarumper kestarumper mentioned this pull request May 28, 2024
@kestarumper kestarumper linked an issue Jun 3, 2024 that may be closed by this pull request
@kestarumper kestarumper merged commit d2b924a into master Jun 3, 2024
6 of 7 checks passed
@kestarumper kestarumper deleted the deprecate-bridge-simple-schema branch June 3, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Bridge Affects some of the bridge packages Area: Core Affects the uniforms package Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies) Bridge: SimpleSchema Affects the uniforms-bridge-simple-schema package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate packages
5 participants