-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate uniforms-bridge-simple-schema
package
#1323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpospiech
requested review from
Monteth,
zaxovaiko,
zendranm and
ErnestTeluk
April 20, 2024 16:16
github-actions
bot
added
Area: Bridge
Affects some of the bridge packages
Area: Core
Affects the uniforms package
Area: Docs
Affects the documentation or reproductions seed
Area: Infra
Affects the repository itself (e.g., CI, dependencies)
Bridge: SimpleSchema
Affects the uniforms-bridge-simple-schema package
labels
Apr 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1323 +/- ##
==========================================
- Coverage 94.37% 94.24% -0.14%
==========================================
Files 229 226 -3
Lines 3754 3664 -90
Branches 1011 989 -22
==========================================
- Hits 3543 3453 -90
Misses 81 81
Partials 130 130 ☔ View full report in Codecov by Sentry. |
kestarumper
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add warn admonition to mark it in the docs as deprecated.
kestarumper
previously approved these changes
May 10, 2024
zendranm
previously approved these changes
May 24, 2024
Monteth
previously approved these changes
May 24, 2024
piotrpospiech
dismissed stale reviews from Monteth, zendranm, and kestarumper
via
May 24, 2024 11:09
ee87287
zaxovaiko
approved these changes
May 24, 2024
kestarumper
approved these changes
May 27, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Bridge
Affects some of the bridge packages
Area: Core
Affects the uniforms package
Area: Docs
Affects the documentation or reproductions seed
Area: Infra
Affects the repository itself (e.g., CI, dependencies)
Bridge: SimpleSchema
Affects the uniforms-bridge-simple-schema package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the Meteor SimpleSchema bridge, as mentioned in this issue (#1315).
uniforms-bridge-simple-schema
package from thepackage.json
filestsconfig
references__mocks__
directory configNote
I left the
SimpleSchemaBridge
docs. We will keep that in the uniforms v3 docs.