From 844f8f6d64b4ca4dcc0c6b91fd21e1faa5a5f943 Mon Sep 17 00:00:00 2001 From: Victor Ribeiro Boechat Date: Fri, 17 May 2024 21:55:49 -0300 Subject: [PATCH 1/3] build: add nodes types dev dependency --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index a64d3ad..ca44f3b 100644 --- a/package.json +++ b/package.json @@ -23,6 +23,7 @@ "test": "vitest" }, "devDependencies": { + "@types/node": "^20.12.12", "axios": "^1.6.8", "typescript": "^5.4.5", "vitest": "^1.6.0" From af08afabd7e76e3031659f79fee4a136e4085433 Mon Sep 17 00:00:00 2001 From: Victor Ribeiro Boechat Date: Fri, 17 May 2024 21:56:18 -0300 Subject: [PATCH 2/3] chore: add strict, esModuleInterop, skipLibCheck and moduleResolution props to tsconfig --- tsconfig.json | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tsconfig.json b/tsconfig.json index 888ec64..38597f0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -5,8 +5,12 @@ "declaration": true, "declarationDir": "./dist", "emitDeclarationOnly": false, - "module": "commonjs", - "target": "es6" + "target": "ESNext", + "module": "NodeNext", + "strict": true, + "esModuleInterop": true, + "skipLibCheck": true, + "moduleResolution": "NodeNext" }, "include": ["src"] } From b25c8809bf0f774ba69195d3b0b8e84c46685180 Mon Sep 17 00:00:00 2001 From: Victor Ribeiro Boechat Date: Fri, 17 May 2024 21:56:49 -0300 Subject: [PATCH 3/3] ci: build project after test to ensure success buildingbefore merging pull requests --- .github/workflows/pr-tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/pr-tests.yml b/.github/workflows/pr-tests.yml index 39d38ed..5ba2eb0 100644 --- a/.github/workflows/pr-tests.yml +++ b/.github/workflows/pr-tests.yml @@ -22,3 +22,6 @@ jobs: - name: Test project run: yarn test + + - name: Build project + run: yarn build