Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPED_TEST_CASE is deprecated, please use TYPED_TEST_SUITE #6

Open
anb0s opened this issue Dec 2, 2019 · 1 comment
Open

TYPED_TEST_CASE is deprecated, please use TYPED_TEST_SUITE #6

anb0s opened this issue Dec 2, 2019 · 1 comment

Comments

@anb0s
Copy link

anb0s commented Dec 2, 2019

I'm facing compile error if compiling with Googletest 1.10 or master/latest:

---------- ERRORS occurred while compiling file D:\git\s7p\work3\s7p.base\vdk\signals-master\tests\tests.cpp
In file included from D:\git\s7p\work3\s7p.base\google\test-1.10\googletest\include/gtest/gtest.h:71,
                 from D:/git/s7p/work3/s7p.base/vdk/signals-master/tests/tests.cpp:14:
D:\git\s7p\work3\s7p.base\google\test-1.10\googletest\include/gtest/gtest-typed-test.h:227:38: error: 'constexpr bool testing::internal::TypedTestCaseIsDeprecated()' is deprecated: TYPED_TEST_CASE is deprecated, please use TYPED_TEST_SUITE [-Werror=deprecated-declarations]
  227 |   static_assert(::testing::internal::TypedTestCaseIsDeprecated(), ""); \
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~
D:/git/s7p/work3/s7p.base/vdk/signals-master/tests/tests.cpp:201:1: note: in expansion of macro 'TYPED_TEST_CASE'
  201 | TYPED_TEST_CASE(SignalsTest, TestTypes);
      | ^~~~~~~~~~~~~~~

Renaming from TYPED_TEST_CASE to TYPED_TEST_SUITE solves the problem.

@anb0s
Copy link
Author

anb0s commented Apr 2, 2020

Do you have plans to update for googletest 1.10 or master?

If yes i can provide a PR for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant