Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace unconditional typing_extensions imports #3683

Merged
merged 1 commit into from
Nov 15, 2024
Merged

refactor: Replace unconditional typing_extensions imports #3683

merged 1 commit into from
Nov 15, 2024

Conversation

dangotbanned
Copy link
Member

Related

Description

This PR moves the remaining typing_extensions imports into version-gated blocks.

I'd been doing this over the past month or so in any PRs that I noticed them in, but these are the last ones.

For anyone new to this issue, this aligns with the dependency spec listed in:

altair/pyproject.toml

Lines 14 to 18 in 1d576a8

[project]
name = "altair"
authors = [{ name = "Vega-Altair Contributors" }]
dependencies = [
"typing_extensions>=4.10.0; python_version<\"3.14\"",

@dangotbanned dangotbanned enabled auto-merge (squash) November 15, 2024 14:18
mattijn
mattijn approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@mattijn mattijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dangotbanned dangotbanned merged commit ab3e250 into main Nov 15, 2024
25 checks passed
@dangotbanned dangotbanned deleted the typing-extensions-soft-depends branch November 15, 2024 14:29
@dangotbanned dangotbanned linked an issue Nov 17, 2024 that may be closed by this pull request
TypeError on Import - TypeError: _TypedDictMeta.__new__() got an unexpected keyword argument 'closed' #3684
Closed
@dangotbanned dangotbanned mentioned this pull request Nov 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattijn mattijn mattijn approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError on Import - TypeError: _TypedDictMeta.__new__() got an unexpected keyword argument 'closed'
2 participants
@dangotbanned @mattijn