Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No duplicate checking on white/blacklist #15

Open
amandaschloss opened this issue Sep 18, 2015 · 3 comments
Open

No duplicate checking on white/blacklist #15

amandaschloss opened this issue Sep 18, 2015 · 3 comments

Comments

@amandaschloss
Copy link
Contributor

No description provided.

@magni-
Copy link

magni- commented Sep 30, 2015

Any reason not to use sets? We don't care about list order, right?

@magni-
Copy link

magni- commented Sep 30, 2015

Do we want to silently pass or raise when doing a duplicate add to white/blacklist?

@amandaschloss
Copy link
Contributor Author

We store Features as serialized JSON, which doesn't support sets. I could go either way on the pass/raise question; @magni- @anthonyyim thoughts?

@magni- magni- mentioned this issue Oct 1, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amandaschloss @magni-