Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Custom class that is same as ModKMeans #117

Open
RunKZhang opened this issue Aug 2, 2023 · 3 comments · May be fixed by #118
Open

Adding a Custom class that is same as ModKMeans #117

RunKZhang opened this issue Aug 2, 2023 · 3 comments · May be fixed by #118

Comments

@RunKZhang
Copy link

Hey everyone,

I am thinking of adding a new class in the cluster module. In some situations, users may implement new algorithms or methods to do clustering on gfp data rather than using K-means or AAHC. However, there is a lack of corresponding class to integrate the results obtained by new algorithms or methods with the entire pycrostates workflow.

I am very happy to help improve the pycrostates, and I am working on implementing this custom and general class.
@mscheltienne
Copy link
Collaborator

Do you mean a ClusterArray object, similar to what RawArray is for Raw in MNE-Python?

@RunKZhang
Copy link
Author

Yes, something like that but not very similar. Has ClusterArray implemented yet?

@mscheltienne
Copy link
Collaborator

No it's not implemented, and from your PR it looks to me like that's the idea.
+1 to add this object for user-defined clusters.

@mscheltienne mscheltienne linked a pull request Aug 2, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ClusterArray class to import any kind of microstates maps RunKZhang/pycrostates
2 participants
@mscheltienne @RunKZhang