Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-validation / collaboration #17

Open
DominiqueMakowski opened this issue Feb 19, 2022 · 2 comments
Open

Cross-validation / collaboration #17

DominiqueMakowski opened this issue Feb 19, 2022 · 2 comments
Labels
❔ question Further information is requested

Comments

@DominiqueMakowski
Copy link

Hey folks, I stumbled on this repo thanks to @mscheltienne, and it looks great! I'm happy to see more work being done on microstates :)

I simply wanted to point out that we did a bit of work on that a few months ago for neurokit, comparing the different existing packages and going back to the original formulations and equations.

https://github.com/neuropsychology/NeuroKit/tree/master/neurokit2/microstates

See example here

As I see you're actively working on this, I'd be very interested if you guys could eventually run some validation or benchmarking so that we can compare our implementations, to make sure they are correct and the most efficient. It's always good to double-check

Let me know what you think!

@mscheltienne
Copy link
Collaborator

Hey, sorry for the late reply, and I'll let Victor comment if he disagrees, but I think it would be great to compare and cross-validate the 2 implementations. However, we are a bit short on time for now, and personally, I won't have time to allocate to this for now.

I think a good first step would be to pick a common dataset (MNE dataset?) and write the clustering code for it in both neurokit2 and pycrostates.

@vferat
Copy link
Owner

vferat commented Feb 22, 2022

Hey Dominique,

Thanks for reaching us ! Indeed It would be a good idea to collaborate on this.
I recently implemented a fetcher for the mind-brain-body dataset with more than 200 pre-processed EEG available. We could use it to run some validation and benchmarking.

If you are interested, you can reach me by email at [email protected] so we can organize a virtual meeting to discuss this in more details.

@vferat vferat added the ❔ question Further information is requested label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants