Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-3338-fix-stability-of-vision-capture-all-from-camera #4557

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nicksanford
Copy link
Member

@nicksanford nicksanford commented Nov 15, 2024

  1. Change signature of collectors from (ctx context.Context, _ map[string]*anypb.Any) (interface{}, error) to (ctx context.Context, _ map[string]*anypb.Any) (data.CaptureResult, error) see data/collector_types.go for more info
  2. Change CaptureFuncs to determine the capture request and response time rather than data/collector.go
  3. Change all tabular collectors to use data.NewTabularCaptureResult to create tabular capture results.
  4. Update collector tests to assert on multiple sensor data values
  5. Update data sync to accept binary capture files with multiple readings (as in the case of camera.GetImages)
  6. Update data sync to handle both legacy camera.GetImages capture files and the new, more efficient ones
  7. Update data sync to set both the datasyncpb.MimeType and the datasyncpb.UploadMetadata.FileExtension fields
  8. Update data sync to move capture file to failed directory in cases where the capture file contains unrecoverable data (such as multiple capture types within a given capture file, or the capture file header type being something other than binary or tabular)

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 15, 2024
@nicksanford nicksanford force-pushed the DATA-3338-fix-stability-of-vision-capture-all-from-camera-2 branch from 33c6fab to 501209a Compare November 18, 2024 18:04
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 18, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 19, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 20, 2024
@nicksanford nicksanford force-pushed the DATA-3338-fix-stability-of-vision-capture-all-from-camera-2 branch from 24f1702 to 842ea82 Compare November 21, 2024 19:51
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 21, 2024
@nicksanford nicksanford force-pushed the DATA-3338-fix-stability-of-vision-capture-all-from-camera-2 branch from 842ea82 to 583a8e6 Compare November 21, 2024 19:54
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 21, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 21, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 21, 2024
GetImages = "GetImages"
nextPointCloud = "NextPointCloud"
pointCloudMap = "PointCloudMap"
captureAllFromCamera = "CaptureAllFromCamera"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added captureAllFromCamera to binary methods

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 21, 2024
}

// GetFileExt gets the file extension for a capture file.
func GetFileExt(dataType v1.DataType, methodName string, parameters map[string]string) string {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -240,49 +240,6 @@ func getFileTimestampName() string {
return time.Now().Format(time.RFC3339Nano)
}

// TODO DATA-246: Implement this in some more robust, programmatic way.
func getDataType(methodName string) v1.DataType {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return true
}

for _, e := range terminalCaptureFileErrs {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicksanford nicksanford marked this pull request as ready for review November 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants