Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-9251] - Add options helpers to stream client #418

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

seanavery
Copy link
Member

@seanavery seanavery commented Nov 22, 2024

Description

This PR adds a few helpers to interact with dynamic resolution stream server endpoints.

Tests

Added success and failure test cases for the new stream interface methods.

@seanavery seanavery requested a review from a team as a code owner November 22, 2024 19:49
@seanavery seanavery changed the title [RSDK-9251] - Add stream options helpers to stream client [RSDK-9251] - Add options helpers to stream client Nov 22, 2024
@seanavery
Copy link
Member Author

It looks like the npm check is returning 1 in CI... Would it be ok to bump these dependencies?

> @viamrobotics/[email protected] check
> npm-check --production --ignore=@bufbuild/protobuf

- Checking for unused packages. --skip-unused if you don't want this.
- Checking npm registries for updated packages.

@connectrpc/connect       😎  MAJOR UP  Major update available. https://github.com/connectrpc/connect-es#readme
                                       npm install @connectrpc/[email protected] --save to go from 1.6.1 to 2.0.0

@connectrpc/connect-web   😎  MAJOR UP  Major update available. https://github.com/connectrpc/connect-es#readme
                                       npm install @connectrpc/[email protected] --save to go from 1.6.1 to 2.0.0

Use npm-check -u for interactive update.
make: *** [Makefile:34: lint] Error 1

@randhid randhid removed their request for review November 23, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant