Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sass deprecations for colour syntax #8876

Open
rtritto opened this issue Sep 22, 2024 · 1 comment · May be fixed by #8894
Open

Sass deprecations for colour syntax #8876

rtritto opened this issue Sep 22, 2024 · 1 comment · May be fixed by #8894
Labels
needs: triage This issue needs to be reviewed

Comments

@rtritto
Copy link

rtritto commented Sep 22, 2024 •
edited
Loading

Description

After I updated sass-embedded to version 1.79.3

Deprecation [legacy-js-api]: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api
Deprecation Warning: lighten() is deprecated. Suggestions:

color.scale($color, $lightness: 41.6584158416%)
color.adjust($color, $lightness: 33%)

More info: https://sass-lang.com/d/color-functions

  ╷
9 │ $secondary-background-color: lighten($primary-background-color, 33%) !default;
  │                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
    file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/_private-variables.scss 9:30  @import
    file:///C:/<PROJECT_PATH>/node_modules/video.js/src/css/video-js.scss 3:9             @import
    file:///C:/<PROJECT_PATH>/src/scss/videojs.scss 2:9                                   root stylesheet

Steps to reproduce

  1. Install sass or sass-embedded
  2. Add @import 'video.js/src/css/video-js.scss'; in the scss file and import it.
  3. See the logs

Errors

No response

What version of Video.js are you using?

8.18.1
@rtritto rtritto added the needs: triage This issue needs to be reviewed label Sep 22, 2024
@rtritto
Copy link
Author

rtritto commented Oct 5, 2024

FYI @mister-ben @gkatsev

@mister-ben mister-ben linked a pull request Oct 11, 2024 that will close this issue
Open
6 tasks
@rtritto rtritto changed the title Sass deprecations Sass deprecations for colour syntax Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update sass and change colour syntax mister-ben/video.js
1 participant
@rtritto