UndefinedThisPropertyFetch despite property_exists() check

[caugner]

https://psalm.dev/r/6cfebb5320

Shouldn't the property_exists() check have the same effect as isset()?

https://psalm.dev/r/58bb4ad896

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/6cfebb5320

<?php

abstract class Base
{
    public function getId(): mixed
    {
        if (!property_exists($this, 'id')) {
            throw new \Exception("Missing id property.");
        }
        
        return $this->id;
    }
}

Psalm output (using commit 77e84b3):

ERROR: UndefinedThisPropertyFetch - 11:16 - Instance property Base::$id is not defined

https://psalm.dev/r/58bb4ad896

<?php

abstract class Base
{
    public function getId(): mixed
    {
        if (isset($this->id)) {
            throw new \Exception("Missing id property.");
        }
        
        return $this->id;
    }
}

Psalm output (using commit 77e84b3):

No issues!

[caugner]

Sorry, it should be !isset instead of isset:

https://psalm.dev/r/1b76e227ca

Weirdly Psalm does NOT emit the UndefinedThisPropertyFetch after the isset, even though the property id most likely does NOT exist after the isset check.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/1b76e227ca

<?php

abstract class Base
{
    public function getId(): mixed
    {
        if (!isset($this->id)) {
            throw new \Exception("Missing id property.");
        }
        
        return $this->id;
    }
}

Psalm output (using commit 77e84b3):

No issues!

[orklah]

duplicate of #2206

[AndrolGenhald]

Reopening for https://psalm.dev/r/58bb4ad896 which is distinct from #2206.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/58bb4ad896

<?php

abstract class Base
{
    public function getId(): mixed
    {
        if (isset($this->id)) {
            throw new \Exception("Missing id property.");
        }
        
        return $this->id;
    }
}

Psalm output (using commit 97bd81c):

No issues!

[gndk]

This should not happen:
https://psalm.dev/r/d206ded407

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d206ded407

<?php

class Stuff
{
}

$value = new Stuff();

if (property_exists($value, 'nonExistingProperty')) {
    if ($value->nonExistingProperty === 'someValue') {
        return;
    }
}

Psalm output (using commit d957ff2):

ERROR: UndefinedPropertyFetch - 10:9 - Instance property Stuff::$nonExistingProperty is not defined

[weirdan]

This now works: https://psalm.dev/r/58bb4ad896

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/58bb4ad896

<?php

abstract class Base
{
    public function getId(): mixed
    {
        if (isset($this->id)) {
            throw new \Exception("Missing id property.");
        }
        
        return $this->id;
    }
}

Psalm output (using commit 8f39de9):

No issues!

[orklah]

Closing this then. #2206 will track the property_exists issue

[AndrolGenhald]

Actually still broken. It should be a !isset() not isset(), and Psalm doesn't catch it.

https://psalm.dev/r/58bb4ad896

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/58bb4ad896

<?php

abstract class Base
{
    public function getId(): mixed
    {
        if (isset($this->id)) {
            throw new \Exception("Missing id property.");
        }
        
        return $this->id;
    }
}

Psalm output (using commit 8f39de9):

No issues!