PossiblyNullPropertyFetch after check with nullsafe operator

[Syzgyn]

https://psalm.dev/r/2d78032069

I could be wrong, but it seems to me that if you check for not-null against something using a null safe operator, then it should validate the entire chain as not null, but that's not what happens.

For example assert($a->b?->c?->d?->e != null) should mean that a through e are all not null, correct? Otherwise the assert would fail.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/2d78032069

<?php

class a
{
    public ?b $b = null;
}

class b
{
    public ?int $c = null;
}

function test(a $a): void
{
	// This breaks...
    if ($a->b?->c != null) {
        echo $a->b->c;
    }
    
    // ...but is equivalent to this, right?
    if ($a->b != null && $a->b->c != null) {
    	echo $a->b->c;
	}
}

Psalm output (using commit f3fc112):

ERROR: PossiblyNullPropertyFetch - 17:14 - Cannot get property on possibly null variable $a->b of type b|null

[signor-pedro]

Experiencing the same.

Here is a snippet:

if ($criteria?->publishedAfter) {
    $queryBuilder->setParameter('publishedAfter', $criteria->publishedAfter);
}

This should be type-safe I guess?

[tm1000]

Another useful example: https://psalm.dev/r/86ffcdda1f

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/86ffcdda1f

<?php

function foo(): void {
    /** @var object|null */
    $foo = new stdClass();
    if($foo?->bar === null) {
		return;
	}
    
    /** @psalm-trace $foo */
}

Psalm output (using commit 5baf85e):

INFO: Trace - 10:0 - $foo: null|object

[SCIF]

Hi @tm1000 , @Syzgyn ,

Looks like this could be fixed in master branch. At least it does for me.

[tm1000]

@SCIF the two snippets still fail in the same way so this doesn't seem resolved