Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for d/vcf_certificate_authority #206

Open
4 tasks done
insidepacket opened this issue Jul 30, 2024 · 3 comments
Open
4 tasks done

Add support for d/vcf_certificate_authority #206

insidepacket opened this issue Jul 30, 2024 · 3 comments
Assignees
Labels
datasource Provider Datasource enhancement Enhancement
Milestone

Comments

@insidepacket
Copy link
Contributor

insidepacket commented Jul 30, 2024

Code of Conduct

  • I have read and agree to the project's Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Add data resource for certificate_authority that can be used in the certificate renewal and other related resources.

Use Case(s)

When we replace a certificate for a domain resource (VCENTER, SDDC_MANAGER) with another certificate, we need to add the certificate_authority resource to the TF template. This makes the certificate_authority resource editable, which is unnecessary for certificate renewal. It also (1) adds unnecessary complexity by including the CA configuration in a certificate renewal TF template, (2) introduces a risk of incorrect CA configuration changes due to human error, and (3) prevents customers from using terraform destroy for the cert renewal TF template as it will remove the CA configuration.

Potential Configuration

data vcf_certificate_authority "example" {
    name = var.ca_name
    type = "microsoft"
}

References

No response

@insidepacket insidepacket added enhancement Enhancement needs-review Needs Review labels Jul 30, 2024
@github-actions github-actions bot added the pending-review Pending Review label Jul 30, 2024
@tenthirtyam tenthirtyam added datasource Provider Datasource and removed needs-review Needs Review pending-review Pending Review labels Jul 30, 2024
@tenthirtyam tenthirtyam added this to the Backlog milestone Jul 30, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 30, 2024
@tenthirtyam tenthirtyam changed the title Add data source for certificate_authority Add support for `d/vcf_certificate_authority Jul 30, 2024
@tenthirtyam tenthirtyam changed the title Add support for `d/vcf_certificate_authority Add support for d/vcf_certificate_authority Jul 30, 2024
@tenthirtyam tenthirtyam modified the milestones: Backlog, v0.11.0 Jul 30, 2024
@tenthirtyam
Copy link
Collaborator

Assigned to Ryan Johnson, VMware by Broadcom.

@tenthirtyam
Copy link
Collaborator

Reassigned to David Zhang, VMware by Broadcom.

@tenthirtyam tenthirtyam modified the milestones: v0.11.0, On Deck Aug 22, 2024
Copy link

'Marking this issue as stale due to inactivity. This helps us focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context.
Thank you!'

@github-actions github-actions bot added the stale Stale label Oct 22, 2024
@tenthirtyam tenthirtyam removed the stale Stale label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource Provider Datasource enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants