-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Runner Update #16
Comments
Same problem here, would unregister and re-register the runner be a workaround? |
Does unregistering a runner also remove it from the gitlab interface? Because if your just delete runners from the config file, you need to additionally manually remove them in the interface |
If I recall if you unregister the runner but the To @tobru point (voxpupuli/puppet-gitlab#120 (comment)) maybe this would need to be implemented with puppet tasks? |
Note: Migrated from voxpupuli/puppet-gitlab#120, opened by @cdenneen
Currently the method of checking
config.toml
for runner exists or not needs to be fixed.While this works for the existence of a runner it doesn't allow for any changes to the runner itself.
The addition of options, tags, image, etc won't generate updated
config.toml
It appears somehow the runner hash needs to be compared to current found hash in the
config.toml
to determine if the runner has updated or not.To reproduce:
to
Will not update the config.toml to the following:
Also the tag update for the runner isn't something that gets written to
config.toml
but updated in gitlab so that needs to be checked as well.Only solution so far would be to empty
config.toml
and delete the runners in Gitlab UI... then run puppet and it will recreate the runners with current configuration and proper tags.The text was updated successfully, but these errors were encountered: