Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compose-go to v2 #141

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Bump compose-go to v2 #141

wants to merge 2 commits into from

Conversation

mhutter
Copy link
Member

@mhutter mhutter commented Oct 16, 2024

Summary

Update the Docker Compose dependencies.

TODO

  • The ordering of ports has been changed, this affects us since we use the FIRST port for probes and generated services/ingresses.
  • The ordering of hostnames/labels has been changed.

Closes #115, #136

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@mhutter mhutter added the dependencies Pull requests that update a dependency file label Oct 16, 2024
@mhutter mhutter marked this pull request as draft October 16, 2024 08:54
@mhutter mhutter self-assigned this Oct 16, 2024
@mhutter
Copy link
Member Author

mhutter commented Oct 16, 2024

Unfortunately, in v2 of the compose spec libraries, ports (amongst other things) are now ordered by their value instead of just leaving them in the order they appear in the compose file.

While this would have make sense from the beginning, in our context this is a breaking change for K8ify. We depend on the order of ports to select which one to use for probes for example, and this change may result in different manifests.

Nick proposed to make it mandatory for k8ify users to specify the ports to use for probes etc. via labels. I like this approach since it will cause existing Pipelines to fail instead of just silently rewriting the probe configurations.

@mhutter mhutter changed the title Bump deps Bump compose-go to v2 Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant