Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Only build commonly used binaries #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhutter
Copy link
Member

@mhutter mhutter commented Nov 15, 2024

The default configuration of goreleaser builds windows and 32-bit variants of the binary.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

The default configuration of goreleaser builds windows and 32-bit
variants of the binary.

Signed-off-by: Manuel Hutter <[email protected]>
@mhutter mhutter added the documentation Improvements or additions to documentation label Nov 15, 2024
@mhutter mhutter requested a review from davidgubler November 15, 2024 09:26
@davidgubler
Copy link
Member

davidgubler commented Nov 18, 2024

With this file the build flags are set in three places:

  • Makefile
  • Github pipelines
  • goreleaser config

That's pretty terrible. This stuff should be in one place, not 3. I don't like this but I also have no solutions other than throwing out goreleaser, which I assume is not something you want to do.

@mhutter
Copy link
Member Author

mhutter commented Nov 19, 2024

We could get rid of goreleaser and only publish the Container Images, that would make things much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants