Fixes to enclosure selection logic #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move various helper functions above the Expat XML parsing handlers, instead of having them interleaved. No actual changes.
Refactoring to enable working with multiple enclosures.
Instead of aways manipulating the last element of std::vector<Appcast> (with necessary checks), simply keep the current work-in-progress item as a variable and push it to the vector after parsing is done.
Rework the sparkle:os matching code to be more readable and, above all, correct even in presence of multiple enclosures. To do this, this commit does the following: - Parse all enclosures into a vector, then filter out unsuitable enclosures - From the remaining ones, pick the most specific (e.g. "windows-x64" is used over "windows" or os-less, if both are present) - Skip over appcast items that have only unsuitable enclosures - Renames helper functions to have more clear names. Fixes #276, fixes #281.
Check if an item is valid, i.e. has either a usable enclosure or a link to open in the browser.
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #276 and #281 for a discussion of the issues.
This PR tackles the bugs by rewriting all the related code in a more readable and easier-to-follow way.