Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: login cookie expiry time incorrect #246

Open
1 task done
Quiark opened this issue Feb 2, 2024 · 0 comments
Open
1 task done

[Bug]: login cookie expiry time incorrect #246

Quiark opened this issue Feb 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Quiark
Copy link

Quiark commented Feb 2, 2024

Expected Behavior

when I make a new login, I get a cookie with expiry being 14 days from now

Actual Behavior

I get a cookie with expiry time 14 days after this process has been started. Which could be in the past if the thing has been runing for 2 weeks already.

Possible Solution

The problem is in helpers/cookie.ts which stores static cookies options object with the expiry date set once at start

Steps to reproduce

No response

What version of vendure integration are you using?

1.1.0

What version of Node.js are you using?

18

What browser (and version) are you using?

chrome

What operating system (and version) are you using?

linux

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Quiark Quiark added the bug Something isn't working label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant