Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

[Feature]: prevent duplicate page cached #5

Open
1 task done
marc-arnoult opened this issue Feb 21, 2022 · 0 comments
Open
1 task done

[Feature]: prevent duplicate page cached #5

marc-arnoult opened this issue Feb 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@marc-arnoult
Copy link

How the project can be improved?

Actually we are caching all the params url. But it's not good

  • The node server will take a huge amount of load with the rendering of these pages.
  • Redis store all of theses unnecessary pages.
  • The user can experience multiple delays to see a page.

Imagine a common use case with redirection from partners annonce with an ID in the used by Google Tag Manager for example ( Client side usage ).
We are duplicating all of theses urls in the redis storage.
Capture d’écran 2022-02-21 à 12 00 22

One solution would be to add an allowParamsUrl in the config.

{ 
  allowParamsUrl: ['q', 'prices', 'colors', .... ]
}

With that even with a random param in the url we will render the same cached page.

What are the acceptance criteria?

  • [ ]

Additional information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@marc-arnoult marc-arnoult added the enhancement New feature or request label Feb 21, 2022
@tobyj tobyj mentioned this issue May 12, 2022
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant