Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CONTRIBUTING.md #57

Closed
wants to merge 0 commits into from
Closed

add CONTRIBUTING.md #57

wants to merge 0 commits into from

Conversation

altafan
Copy link
Collaborator

@altafan altafan commented Jul 22, 2019

Closes #56

@altafan altafan requested review from lorenzodisidoro and tiero July 22, 2019 20:36
@tiero
Copy link
Member

tiero commented Jul 23, 2019

I would add more information on the process of review, master-read only, mandatory review and one test suite.

@lorenzodisidoro
Copy link

We could split the file in more paragraphs, something like this:

  • Contributing (modus operandi for opening PRs) where we explain contributing workflow
  • Rules eg. explain opened PR into the comment, linking the related issues, squashing, ...
  • Categories define the boundaries of main PR categories because cannot be mixed (eg. bug fixing, new feature, refactoring, ...)

tiero
tiero requested changes Jul 24, 2019
View reviewed changes
Copy link
Member

@tiero tiero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

tiero
tiero requested changes Jul 26, 2019
View reviewed changes
CONTRIBUTING.md Outdated

Hereafter is detailed how to proceed in order to contribute to Nigiri.

## Rules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make bold on the keywords (master branch, Pull requests etc..)

CONTRIBUTING.md Outdated
@@ -0,0 +1,35 @@
# Contributing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link this in the readme.md

@tiero
Copy link
Member

tiero commented Jul 26, 2019

I would keep in hold, meanwhile we find a solution for import paths

@altafan altafan closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiero tiero tiero requested changes

@lorenzodisidoro lorenzodisidoro lorenzodisidoro approved these changes

Assignees

@altafan altafan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md
3 participants
@altafan @tiero @lorenzodisidoro