-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlapping edges still a problem #35
Comments
still not fixed after #42 |
Has there been any progress made on this issue? This would be a nice bug to have fixed as it resolves several issues for a project I'm working on. |
We tried to tackle it, but so far to no avail. Of course it would be nice! |
I'm running into what I think is this issue as well. Here's a simple test case that demonstrates the problem. Run 'Difference A-B' to see the problem: https://codepen.io/mfogel/pen/jYgxmm Poly A: [[
[0,0],
[3,0],
[3,3],
[0,3],
[0,0]
]] Poly B: [[
[1,0],
[2,0],
[2,4],
[1,4],
[1,0]
]] |
Thanks for a simple testcase |
@w8r no prob, happy to help Just want to mention that it appears this bug can also manifest itself as a heap overflow, crashing the browser/node altogether. Here's an example, similar to the case I posted earlier. Run 'Difference A-B': https://codepen.io/mfogel/pen/baXjGO Poly A: (a Polygon, same as before) [[ [0,0], [3,0], [3,3], [0,3], [0,0] ]] Poly B: (a MultiPolygon) [
[[ [1,0], [2,0], [2,4], [1,4], [1,0] ]],
[[ [2,0], [3,0], [3,1], [2,1], [2,0] ]]
] Seems possible to me that martinez is:
I'll try to find some time this weekend to help out on this. |
Martinez still has at least one blocking issue, namely w8r/martinez#35
…/martinez into mfogel-fix-overlapping-edges-#35
Fix overlapping edges w8r#35
Look at this codepen:
https://codepen.io/anon/pen/LLdEbM
Polygon 1:
Polygon 2:
The text was updated successfully, but these errors were encountered: