perf: enable compress minify option for node target #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found that this optimization breaks a lot of test snapshots, some of the changes are unexpected. For example, the code readability may be significantly worse. I'm now tending to make this optimization opt-in. If users want a smaller Node.js bundle, they can manually set the minify configuration. |
Do we need to encapsulate a configuration, or we can just document how to configure it if a smaller bundle is needed? |
|
I think adding documentation is good enough for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For the Node target, keep output bundles as small as possible while retaining the necessary information for debugging, as Node outputs usually executed directly at runtime rather than being built again.
See web-infra-dev/rsbuild#3966 for more.
Checklist