Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check URL is in app scope before opening in new standalone window #195

Open
benfrancis opened this issue Mar 20, 2018 · 0 comments
Open
Labels
Milestone

Comments

@benfrancis
Copy link
Member

Currently the window manager looks for an appId in e.detail.options of an open window event and if an app with that ID is found in the database it creates a new standalone window and navigates it to the URL provided.

It should check that the URL is actually in the scope of the app before loading that URL in the standalone window because any web page could add an appId to the event detail but provide an arbitrary URL. This is a vector for phishing attacks.

@benfrancis benfrancis added this to the 0.3 milestone Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant