-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not expose exact download progress #15
Comments
Some offline discussed suggested we should do this censoring, but we should be sure that the values are granular enough that developers still see progress every 50 ms in the typical case. That is, if we just used the integers 1-100, it's possible that for large models it'd take longer than 50 ms to move from 1 to 2. Some rough numbers for order-of-magnitude:
We have a few ways to accomplish this:
I feel pretty strongly that we should update I'm unsure on the choice between (2) and (3). @tomayac points out that HTML's |
Developers are lazy (I am), so any normalization to the |
@annevk as XHR owner, any initial reactions to extending |
Probably okay? |
Probably we should not expose the exact model size during the download progress, as doing so basically lets you know the model ID. This is a slight fingerprinting and compatibility concern. We could instead expose the nearest percent or tenth of a percent.
Are there any concerns about this?
The text was updated successfully, but these errors were encountered: