Skip to content

Commit

Permalink
chore: Make dev password more escure! (#4425)
Browse files Browse the repository at this point in the history
## Description

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
  • Loading branch information
kof authored Nov 15, 2024
1 parent d1a8fdd commit c843747
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

## Before merging

- [ ] tested locally and on preview environment (preview dev login: 5de6)
- [ ] tested locally and on preview environment (preview dev login: 0000)
- [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2 changes: 1 addition & 1 deletion apps/builder/app/services/auth.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ if (env.DEV_LOGIN === "true") {
.toString()
.split(":");

if (secret === env.AUTH_SECRET?.slice(0, 4)) {
if (secret === env.AUTH_SECRET) {
try {
const context = await createContext(request);

Expand Down

0 comments on commit c843747

Please sign in to comment.