Update ESLint and use new config format

Closes #412.

__tests__/integration.js

@@ -3,7 +3,6 @@
 // The sample config should suffice for just starting up the server.
 // We may need something fancier if the integration tests get more in-depth.
 jest.mock("../private-config.json", () => {
-  // eslint-disable-next-line global-require
   return require("../private-config.sample.json");
 }, { virtual: true });
 

eslint.config.mjs

@@ -0,0 +1,31 @@
+import domenicConfig from "@domenic/eslint-config";
+import globals from "globals";
+
+export default [
+  {
+    ignores: ["coverage/**/*"]
+  },
+  {
+    files: ["**/*.js"],
+    languageOptions: {
+      sourceType: "commonjs",
+      globals: globals.node
+    }
+  },
+  ...domenicConfig,
+  {
+    rules: {
+      camelcase: ["error", { properties: "never" }]
+    }
+  },
+  {
+    files: ["__tests__/**/*.js"],
+    languageOptions: {
+      globals: globals.jest
+    },
+    rules: {
+      // Plays poorly with how we set up mocks.
+      "no-loop-func": "off"
+    }
+  }
+];

lib/get-user-status.js

@@ -184,7 +184,7 @@ async function isOrgMember(org, username) {
   try {
     await gitHubAPI.orgs.checkPublicMembershipForUser({ org, username });
     return true;
-  } catch (e) {
+  } catch {
     return false;
   }
 }

lib/helpers/private-config.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-disable global-require */
 
 let privateConfig;
 const privateConfigFromEnv = process.env.PRIVATE_CONFIG_JSON;

lib/process-agreement.js

@@ -124,7 +124,7 @@ function getEntityInfo(body) {
 
   try {
     info.url = (new URL(info.url)).href;
-  } catch (e) {
+  } catch {
     throw new BadRequest("The given 'url' could not be parsed as a URL");
   }
 

lib/routes.js

@@ -125,7 +125,7 @@ module.exports = [
       let parsedURL;
       try {
         parsedURL = new URL(pr);
-      } catch (e) {
+      } catch {
         throw new BadRequest("The pull request URL parameter must be a valid URL.");
       }