New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly unintended synchronisation of ReceiptMessage #343

Open

hrdl-github opened this issue Nov 5, 2024 · 0 comments

Contributor

hrdl-github commented Nov 5, 2024

As described in whisperfish/presage#290 (comment), gurk/presage triggers https://github.com/signalapp/Signal-Android/blob/0891a161b2d2b5de819f98d829370a8f12e7c124/libsignal-service/src/main/java/org/whispersystems/signalservice/api/messages/EnvelopeContentValidator.kt#L195 ([DataMessage] Missing timestamp!) in other clients. I believe this to be due to libsignal-service-rs trying to synchronising ReceiptMessages

libsignal-service-rs/src/sender.rs

Line 416 in 6401dc3

if needs_sync || is_multi_device {

, leaving not much more than the field unidentifiedStatus.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment