Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsignal to v0.32.0 #245

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update libsignal to v0.32.0 #245

merged 1 commit into from
Sep 20, 2023

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Sep 13, 2023

Fixes #244 (and long running issues with upgrading dependencies since zeroize was pinned by curve25519-dalek was bumped to 4.0.0)

Just a draft for now because I haven't tested it yet 😂

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (477c739) 3.78% compared to head (060bba0) 3.73%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #245      +/-   ##
========================================
- Coverage   3.78%   3.73%   -0.06%     
========================================
  Files         38      38              
  Lines       2776    2815      +39     
========================================
  Hits         105     105              
- Misses      2671    2710      +39     
Files Changed Coverage Δ
libsignal-service/src/account_manager.rs 0.00% <ø> (ø)
libsignal-service/src/cipher.rs 0.00% <ø> (ø)
libsignal-service/src/groups_v2/manager.rs 0.00% <ø> (ø)
libsignal-service/src/groups_v2/operations.rs 0.00% <0.00%> (ø)
libsignal-service/src/profile_service.rs 0.00% <ø> (ø)
libsignal-service/src/provisioning/manager.rs 0.00% <ø> (ø)
libsignal-service/src/provisioning/mod.rs 0.00% <ø> (ø)
libsignal-service/src/push_service.rs 0.00% <0.00%> (ø)
libsignal-service/src/sender.rs 0.00% <ø> (ø)
libsignal-service/src/service_address.rs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boxdot
Copy link
Contributor

boxdot commented Sep 14, 2023

Tested with whisperfish/presage#188 in gurk CLI client. Works for me.

Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg they got rid of the Context.

I might come back and change to proc-macro2 = "1.0"-style dependencies. That shouldn't conflict with us nor with you.

@gferon
Copy link
Collaborator Author

gferon commented Sep 14, 2023

I'd need to double check that groups sync still works as intended.

@gferon
Copy link
Collaborator Author

gferon commented Sep 20, 2023

Omg they got rid of the Context.

In theory, this means Send is possible now.

@gferon gferon marked this pull request as ready for review September 20, 2023 15:36
@gferon gferon merged commit 8305357 into main Sep 20, 2023
10 of 11 checks passed
@gferon gferon deleted the update-libsignal-0.32.0 branch September 20, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to libsignal v0.31 or later
3 participants