Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV 1.61 #248

Merged
merged 6 commits into from
Sep 23, 2023
Merged

MSRV 1.61 #248

merged 6 commits into from
Sep 23, 2023

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Sep 23, 2023

Supersedes #149. Whisperfish will not be able to update libsignal-service for a while since libsignal-client 0.32, but we'll take that hit internally. You folks don't have to suffer anymore under 1.52 :-)

@rubdos rubdos mentioned this pull request Sep 23, 2023
@gferon gferon enabled auto-merge (squash) September 23, 2023 19:54
@gferon gferon disabled auto-merge September 23, 2023 20:01
@gferon gferon merged commit 35f9656 into main Sep 23, 2023
8 of 9 checks passed
@gferon gferon deleted the 1.61 branch September 23, 2023 20:02
@gferon
Copy link
Collaborator

gferon commented Sep 23, 2023

@rubdos I merged this but then realized that 1.61 currently fails because we require a lower minor version of tempfile. I suppose we need to check-in a lockfile?

@rubdos
Copy link
Member Author

rubdos commented Sep 24, 2023

Looks like the suffering at MSRV 1.61 has already started. Tokio has 1.63 as MSRV, prost claims 1.60, but in practice it's already 1.63 too. tempfile and a bunch of others (petgraph) are what kills the story transitively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants