[Partial revert] Make sure we use the provided CSPRNG everywhere #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gferon
changed the title
gferon
force-pushed
the
rng-template-param
branch
from
839a99a
to
0fb2030
Compare
gferon
force-pushed
the
rng-template-param
branch
from
0fb2030
to
2d9088e
Compare
|
It makes sense both ways. By #331, we chose that we are an opinionated library. By being generic, we show we're flexible. Either way is fine by me. |
rubdos
approved these changes
Nov 5, 2024
|
@gferon conflicts here :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just merged #341 but after talking with @boxdot the correct change is to do the opposite: make sure we use whatever the library user provide as CSPRNG.
Note: the
csprng: &mut Ris supposed to be at the end of function parameters to mimick whatlibsignaldoes and make it consistent.There are only two places where we still use
rand::thread_rng: in tests and when generating an ID for the next websocket request.