Pop up log in for logged out users #5086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-olson1214
requested review from
a team and
tonisevener
and removed request for
a team
tonisevener
previously requested changes
Nov 22, 2024
l-olson1214
commented
Nov 22, 2024
# Conflicts: # Wikipedia/iOS Native Localizations/en.lproj/Localizable.strings
mazevedofs
requested changes
Nov 28, 2024
| alert.addAction(action1) | ||
| alert.addAction(action2) | ||
|
|
||
| DonateFunnel.shared.logYearInReviewLoginPromptDidAppearProfile() |
There was a problem hiding this comment.
Maybe move this inside
if let presentedViewController = navigationController.presentedViewController { ... on line 217
so we only log it when it's actually presented instead of logging when it's created.
| @@ -405,6 +405,7 @@ final class YearInReviewCoordinator: NSObject, Coordinator { | |||
| } | |||
|
|
|||
| func start() { | |||
|
|
|||
There was a problem hiding this comment.
very minor - remove extra whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator:
https://phabricator.wikimedia.org/T379794
Notes
Test Steps
Screenshots/Videos
Simulator.Screen.Recording.-.iPhone.15.Plus.-.2024-11-20.at.14.19.42.mp4