Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Populate initial most read slide if needed #5094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tonisevener
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T376069

Notes

This is a bug I found when testing around on Year in Review. In this situation, I had an older app version 7.6.2 on device, displaying Year in Review with the article count. When then running against the main branch, I noticed the most read day slide didn't show as expected.

The reason is here. Since we already had a list of slides persisted, the most read initial slide is never added and this conditional is skipped. So in users who upgrade from 7.6.2 to 7.6.3, they would never see the new slides.

Test Steps

  1. Download TestFlight 7.6.2 build. Ensure region is as expected, build up an article count. Go to app Settings and toggle on and off year in review to display the entry point.
  2. Confirm you see year in review article read count slide.
  3. In this branch, temporarily set WMFRemoteAppConfigCheckInterval = 1 here to force the app to fetch the new remote config.
  4. Then run from this branch, confirm most read day slide appears.

@tonisevener tonisevener requested review from a team and l-olson1214 and removed request for a team November 22, 2024 22:41
@tonisevener tonisevener changed the title [Yir] Populate initial most read slide if needed [YiR] Populate initial most read slide if needed Nov 22, 2024
Copy link
Collaborator

@l-olson1214 l-olson1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some test failures!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants