[YiR] Populate initial most read slide if needed #5094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T376069
Notes
This is a bug I found when testing around on Year in Review. In this situation, I had an older app version 7.6.2 on device, displaying Year in Review with the article count. When then running against the
main
branch, I noticed the most read day slide didn't show as expected.The reason is here. Since we already had a list of slides persisted, the most read initial slide is never added and this conditional is skipped. So in users who upgrade from 7.6.2 to 7.6.3, they would never see the new slides.
Test Steps
WMFRemoteAppConfigCheckInterval = 1
here to force the app to fetch the new remote config.