Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android (11,12,13) - ComponentDidDisappear doesn't invoke when user change tab & bottomTabs.visible=false #7705

Open
1 task done
retyui opened this issue Apr 29, 2023 · 4 comments

Comments

@retyui
Copy link
Contributor

retyui commented Apr 29, 2023

What happened?

Navigation.events().registerComponentDidDisappearListener(event => {
   // event doesn't invoke on Android 13,12,11  :( when user jump between tabs 
})

I found out that Navigation.setDefaultOptions({bottomTabs: {visible: false},}); trigger this behavior

when visible:true then listener invoked as expected :(

Demo Android 13 (no disappear event):

android.mp4

Demo Android 10 (works well):

10.mp4

Demo iOS:

Screen.Recording.2023-04-29.at.12.50.53.mov

What was the expected behaviour?

event should work the same as iOS and old Android versions

Was it tested on latest react-native-navigation?

  • I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

git clone https://github.com/retyui/wix-react-native-navigation-issues-7705
cd wix-react-native-navigation-issues-7705
yarn
yarn start 
yarn android # use Android 13,12,11

then in index.js:

Navigation.setDefaultOptions({
  bottomTabs: {
    visible: false, // <-- Change value to see differences (of invoking Appear/Disappear events)
  },
});

In what environment did this happen?

React Native Navigation version: 7.33.0-alpha.3 + 7.30.3
React Native version: 0.70.6
Has Fabric (React Native's new rendering system) enabled: no
Node version: 16
Device model: pixel 7 pro
Android version: 13

@retyui retyui changed the title Android 13 - ComponentDidDisappear doesn't invoke when user change tab Android - ComponentDidDisappear doesn't invoke when user change tab Apr 29, 2023
@retyui retyui changed the title Android - ComponentDidDisappear doesn't invoke when user change tab Android (11,12,13) - ComponentDidDisappear doesn't invoke when user change tab Apr 29, 2023
@retyui retyui changed the title Android (11,12,13) - ComponentDidDisappear doesn't invoke when user change tab Android (11,12,13) - ComponentDidDisappear doesn't invoke when user change tab & bottomTabs.visible=false May 2, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

@stale stale bot added 🏚 stale and removed 🏚 stale labels Jun 10, 2023
@yogevbd yogevbd self-assigned this Jun 20, 2023
@stale
Copy link

stale bot commented Aug 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

@stale stale bot added 🏚 stale and removed 🏚 stale labels Aug 10, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Sep 16, 2023
@retyui
Copy link
Contributor Author

retyui commented Sep 16, 2023

no

@stale stale bot removed the 🏚 stale label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants