Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 14 compatibility #7751

Closed
1 task done
androideveloper opened this issue Jul 12, 2023 · 5 comments
Closed
1 task done

Android 14 compatibility #7751

androideveloper opened this issue Jul 12, 2023 · 5 comments

Comments

@androideveloper
Copy link

androideveloper commented Jul 12, 2023

What happened?

We are exploring Android 14 and possibility to target it as soon as possible. In Android 14, Runtime-registered broadcasts receivers must specify export behavior.

There's one place in rn-navigation library, where a broadcast is registered without specifying the export behaviour. You can find it here. The way to fix this is bumping androidx.core dependency to be able to use the latest APIs for ContextCompat class.

On the other hand, we've noticed, that this class JsDevReloadHandler is initialized on app start, even for release builds. I've not found any checks for debug/release in the code. Isn't this supposed to run only on debug version of the app?

What was the expected behaviour?

  • JsDevReloadHandler shouldn't be initialized on release builds.
  • registering broadcast receiver should be compatible with android 14

Was it tested on latest react-native-navigation?

  • I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

No response

In what environment did this happen?

React Native Navigation version: 7.32.1
React Native version: 0.71.7
Has Fabric (React Native's new rendering system) enabled: no
Node version: 16.14.2
Device model: Pixel 6 Pro, android 14 beta
Android version: 14

@androideveloper androideveloper changed the title Android 14 compatiblity Android 14 compatibility Jul 12, 2023
@stale
Copy link

stale bot commented Aug 11, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Aug 11, 2023
@androideveloper
Copy link
Author

It's still relevant

@stale stale bot removed the 🏚 stale label Aug 15, 2023
@yogevbd yogevbd self-assigned this Aug 15, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

@ghost
Copy link

ghost commented Nov 3, 2023

I am facing same issue how I can fix this ?

@stale stale bot removed the 🏚 stale label Nov 3, 2023
@yogevbd
Copy link
Collaborator

yogevbd commented Nov 9, 2023

#7801 merged, closing

@yogevbd yogevbd closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants