Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added light/dark mode #151

Merged

Conversation

alefever39
Copy link
Contributor

Summary of changes

  • added light and dark mode
  • changed styling of links

Related Issue

Add a 'dark-mode' to your card ( from issue #4) #93

How to test (for features) / reproduce (for bugs)

N/A

Screenshots

image
image

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation (explains but does not affect functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Notes

  • please consider including a gif that reflects your feelings about this PR

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for scrollodex ready!

Name Link
🔨 Latest commit 385c3f9
🔍 Latest deploy log https://app.netlify.com/sites/scrollodex/deploys/635c3403fa2acf0009a4e403
😎 Deploy Preview https://deploy-preview-151--scrollodex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@jenndiaz jenndiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I really like the linear gradient.

I have a couple of concerns about the "Dark Mode" button. Let me know if you have any questions about my comments.

src/cards/AlliesCard/AlliesCard.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@jenndiaz jenndiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for addressing my comments.

@jenndiaz jenndiaz merged commit 652b543 into women-who-software:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants