why do loaders need to be in context?

[Tsugami]

this is not such an obvious thing when trying to use the lib, and it becomes difficult to use it

suggestion:

1. use the direct loader without having to add it in the context
2. create a required parameter in createLoader to show where to consume the loader

[daniloab]

can you give examples of your idea?

[sibelius]

We need loaders in GraphQL context because they use dataloader under the hood to provide cache and batch for our database queries

you should not share this cache between requests

what do you recommend?

[Tsugami]

Suggestion 1,

https://github.com/entria/graphql-mongo-helpers/blob/master/src/createLoader.ts#L80
context.dataloaders[loaderName]
here it's get from the context, instead it's get direct of createLoader function internally

Suggestion 2,

createLoader({
  name: 'UserLoader',
  getLoader: (ctx) => ctx.userLoader; // here it is optional for the developer to choose where to get it.
})

on second thought, maybe the first suggestion is not so valid, because it creates an instance globally and not for request

[Tsugami]

i didn't understand the need of context loaders, maybe how it's currently is the best way

[sibelius]

I do like your second suggestion, feel free to implement it

add tests to avoid regressions, and keep the old default behavior