[Page File 관리] 로키 미션 제출합니다. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocochip101
reviewed
Sep 2, 2024
Comment on lines
+9
to
+13
| private final Map<String, PagedFile> openFiles; | ||
|
|
||
| public PagedFileManager(Map<String, PagedFile> openFiles) { | ||
| this.openFiles = openFiles; | ||
| } |
There was a problem hiding this comment.
[질문] open된 파일을 메모리에서 갖고 있는 것이 어떤 이점이 있나요?
| @@ -1,19 +1,34 @@ | |||
| package database.page; | |||
|
|
|||
| public class Page { | |||
There was a problem hiding this comment.
Serializable에 대해 학습해보면 좋을것 같습니다.
| @@ -3,7 +3,8 @@ | |||
| public class Application { | |||
|
|
|||
| public static void main(String[] args) { | |||
| DatabaseServer server = new DatabaseServer(3306); | |||
| ParameterHandler parameterHandler = new ParameterHandler(args); | |||
|
|
||
| public class ParameterHandler { | ||
|
|
||
| private static final Map<String, String> DEFAULT_OPTIONS = Map.of( |
Comment on lines
+16
to
+21
| public Page getPage(PageId pageId) { | ||
| if (!pageBuffer.containsKey(pageId)) { | ||
| return null; | ||
| } | ||
| return pageBuffer.get(pageId); | ||
| } |
| } | ||
|
|
||
| public long getPageNum() { | ||
| public int getPageNum() { |
There was a problem hiding this comment.
저도 고민했던 사항인데, 페이지 번호는 평균적으로 int 범위를 넘어갈 정도로 많나요?(궁금)
Comment on lines
+19
to
+20
| private static final String testFileName = "testfile.db"; | ||
| private static final String oldFileName = "oldFile.db"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
페이지는 어떻게 구성되나요?
페이지 교체 알고리즘은 어떤 것으로 결정하고, 왜 결정했나요?
PageReplacementPolicy인터페이스로 추상화 하였습니다.스크레치 페이지