Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function and structure renaming in trace #1346

Closed
1 of 7 tasks
xelatihy opened this issue Mar 8, 2022 · 1 comment
Closed
1 of 7 tasks

Function and structure renaming in trace #1346

xelatihy opened this issue Mar 8, 2022 · 1 comment
Labels
enhancement

Comments

@xelatihy
Copy link
Owner

xelatihy commented Mar 8, 2022 •
edited
Loading

Since trace has now two implementation, on CPU and GPU respectively,
we should rename functions consistently between the implementations.
This means going back to the previous naming scheme that simplifies
names. As usual, backward compatibility will be maintained.

  • rename make_XXX functions
  • trace_XXX functions
  • provide an async trace function if necessary
  • rename get_XXX methods
  • clear the use of denoising functions between the two renderers
  • rename internal structures with simpler names
  • consider the use of an empty context in trace
@xelatihy xelatihy changed the title Function renaming in trace Function and structure renaming in trace Mar 8, 2022
@xelatihy
Copy link
Owner Author

Listed in #1377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xelatihy