We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running hops build with a build error results in the error message being printed twice to the console.
hops build
It should be sufficient to print the message only once.
The reason is that we are having two callbacks for the compilation:
hops/packages/webpack/lib/utils/compiler-fork.js
Lines 58 to 62 in 665eb0f
This will reject the build promise and that results in the handleError hook getting called.
handleError
hops/packages/webpack/mixins/build/mixin.core.js
Line 134 in 665eb0f
And in that hook we just log the error:
hops/packages/info/logger/mixin.core.js
Lines 56 to 58 in 665eb0f
The other place is the logging plugin for webpack:
hops/packages/webpack/lib/plugins/log.js
Line 68 in 665eb0f
The text was updated successfully, but these errors were encountered:
No branches or pull requests
This is my intent (choose one)
The problem
Running
hops build
with a build error results in the error message being printed twice to the console.Proposed solution
It should be sufficient to print the message only once.
The reason is that we are having two callbacks for the compilation:
hops/packages/webpack/lib/utils/compiler-fork.js
Lines 58 to 62 in 665eb0f
This will reject the build promise and that results in the
handleError
hook getting called.hops/packages/webpack/mixins/build/mixin.core.js
Line 134 in 665eb0f
And in that hook we just log the error:
hops/packages/info/logger/mixin.core.js
Lines 56 to 58 in 665eb0f
The other place is the logging plugin for webpack:
hops/packages/webpack/lib/plugins/log.js
Line 68 in 665eb0f
The text was updated successfully, but these errors were encountered: